Handle errors with Promises

cooperka commented 7 years ago

Motivation

Some simulators (for both iOS and Android) don't support activity recognition, and even some real Android devices don't have Google Play Services installed. For these devices, the app may crash with native error logs that never get sent to JS and thus are impossible to handle elegantly.

Changes

Return Promises for start and stop on both Android and iOS
Fail to start on Android if Google Play Services doesn't exist, or on iOS if motion data isn't available (in DEV)
Log issues to the JS console automatically, but allow them to be handled by the client
Use consistent indentation in ActivityRecognition.ios.js
- View the diff with whitespace ignored: https://github.com/Aminoid/react-native-activity-recognition/commit/219f2a37f6e4dc4025d9a5492c8e4c37773f06b8?w=1

Example

ActivityRecognition.start(1000)
  .then(() => console.log('Success'))
  .catch((errorMsg) => console.log(errorMsg));

Notes

Documentation on iOS callbacks: https://facebook.github.io/react-native/docs/native-modules-ios.html#callbacks

cooperka commented 7 years ago

Hi @Aminoid, I noticed you're not watching this repo so I wanted to ping you directly. Do you mind taking a quick look at this PR? Let me know if you want any more info!

reyalpsirc commented 7 years ago

I'll be using your fork while this isn't merged :)

Aminoid commented 7 years ago

Thanks for the pull-request @cooperka. Merged it and is available in release v3.2.0

Aminoid / react-native-activity-recognition