Aminsinichi / wearable-hrv

A Python package for the validation of heart rate and heart rate variability in wearables
MIT License
11 stars 2 forks source link

Installation Problem - Use of deprecated astropy API #1

Closed AKuederle closed 7 months ago

AKuederle commented 9 months ago

Using pip install to install the package in a clean env results in errors during import.

Specficially, ImportError: cannot import name 'LombScargle' from 'astropy.stats'. This is likely related to the deprecation mentioned here (https://github.com/lightkurve/lightkurve/issues/535)

It seems like the package does not support recent astropy versions. That should be specified in the setup.py to ensure that compatible versions are installed (or even better, the newer versions of astropy should be supported).

Downgrading astropy to <6.0 fixed the issue for now

Aminsinichi commented 8 months ago

Thank you very much! Addressed the issue in setup.py by defining atropy<6.0. Related commit.