AmirTheFree / obsidian-dynamic-rtl

Dynamic (Per line/paragraph depend on language you type) RTL/LTR support plugin for Obsidian.md
https://obsidian.md
GNU General Public License v3.0
71 stars 2 forks source link

Incompatiblity with Tasks plugin #9

Closed ma-sadeghi closed 2 years ago

ma-sadeghi commented 2 years ago

dynamic-rtl enabled

image

dynamic-rtl disabled

image

AmirTheFree commented 2 years ago

Solved in 0.2.8. Please update the plugin from app. Thank you for the issue :rose:

ma-sadeghi commented 2 years ago

Amazing! Your plugin is my favorite. RTL compatibility is important enough for it to even be part of the Obsidian app as a core plugin. Anyway, thanks for all your efforts!

AmirTheFree commented 2 years ago

Thanks! RTL Should be fixed from main source code of the app. What I do in the plugin almost is a technical ماله کشی 😉

aliamini87 commented 2 years ago

Obsidian also has RTL support but it is document-based not paragraph-based. They talk about code-mirror as a cause for disability to go beyond document-based RTL. Are they right?

AmirTheFree commented 2 years ago

I know. No they are not right completely. I solved many problems just with a plugin while it does not have access to many things, how it will be if I access the main source code? The user who was in charge to approve the plugin to be published, didn't believe that plugin works in live preview mode (codemirror almost) too until I recorded & uploaded a video for him/her !!! At that time I thought that they were disappointed from bidi documents; but everything is completely possible with HTML+CSS+JS , just needs some nerve & patience :wink:

aliamini87 commented 2 years ago

دمت گرم! موفق باشی.

On Fri, Oct 28, 2022, 7:57 PM Amirreza Aliakbari @.***> wrote:

I know. No they are not right completely. I solved many problems just with a plugin while it does not have access to many things, how it will be if I access the main source code? The user who was in charge to approve the plugin to be published, didn't believe that plugin works in live preview mode too until I recorded & uploaded a video for him/her !!! At that time I thought that they were disappointed from bidi documents; but it is completely possible, just needs some nerve & patience 😉

— Reply to this email directly, view it on GitHub https://github.com/mwxgaf/obsidian-dynamic-rtl/issues/9#issuecomment-1295198537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV3YWYIZKC7MXIV7TCBHWWLWFP5G3ANCNFSM6AAAAAARQ57DV4 . You are receiving this because you commented.Message ID: @.***>

MatanRubin commented 1 year ago

Hi, thank you for this plugin! I encounter this issue using Obsidian 1.0.3 and Dynamic RTL plugin version 0.2.11: image

What am I missing?

AmirTheFree commented 1 year ago

Hi I checked out & could not reach a situation that faces this problem. Do you pressed enter (new line) for the first task? or does changing theme fix the problem?

MatanRubin commented 1 year ago

I tried this again to make sure I don't have anything else installed that might be causing this. I created a new test vault and installed Obsidian Tasks and Dynamic RTL, nothing else. I enabled tasks and set the global filter to #task and enabled the Remove Global Filter setting: image

So far everything works as expected. Now I enabled the Dynamic RTL plugin and switch to viewing mode, and I get this: image

The markdown I entered for this was exactly this:

- [ ] #task task 1
- [ ] #task task 2

Note that you need to restart Obsidian for changes to take effect once you change ANY setting in the Tasks plugin.

AmirTheFree commented 1 year ago

image

I did exactly what you said but I could not face the problem again. I'm sorry I use Things theme (This may help)

MatanRubin commented 1 year ago

I tried it again, this time with the default theme and again with the Things theme. I get the same result each and every time. How can we debug this further? I'd love to give you any output from my environment that might help you identify the issue...

MatanRubin commented 1 year ago

Looking at the HTML in the developer tools shows the issue - in the first task there's an additional div that doesn't exist in the second task.

image

I'm not really sure how the plugin works, but this additional div seems to be the root cause. Do you know why it is added in the first task? Anything I can do to find out?

Edit: If I disable Dynamic RTL, restart Obsidian, and look at the HTML again, we can see these divs don't exist, and the text of the task is directly within the span: image

Any clue to what's going on?

ma-sadeghi commented 1 year ago

Could you maybe create a brand new vault and try again?

MatanRubin commented 1 year ago

This was done in a brand new vault

ma-sadeghi commented 1 year ago

It's very strange, because I can't reproduce it either. I'm using the Minimal theme.

AmirTheFree commented 1 year ago

@MatanRubin & @ma-sadeghi Thank for your help & your detailed info. :rose: The problem is fixed in new version Please update the plugin from app & check if its fixed for you or not :heavy_check_mark:

MatanRubin commented 1 year ago

Awesome! Thank you so much! Will give it a try once the new version is available and report back!

MatanRubin commented 1 year ago

Updated to latest and the issue is resolved! Thank you so much for your help and for this great plugin!