search

AmitGujar / Bink-Chrome-Extension

Bink makes your browser Homescreen Beautiful with Daily new Wallpapers and Motivational Quotes, Weather, and Much More.
MIT License
16 stars 11 forks source link

Changed the link request to 'data.links.download' #30

Closed k-azadzoi closed 4 years ago

k-azadzoi commented 4 years ago

Component: Updated the link on line 131 in the unsplashGetPhotos() function.

When a user clicks on "Download Photo" it would re-direct the user to the unsplash website in order for them to download the photo.

In order to solve the issue I read the docs located here: https://help.unsplash.com/en/articles/2511258-guideline-triggering-a-download Then went to the unsplash website to see how they allow users to download photos directly.

Issue # 29

I tried to follow the contributing docs as much as possible so I apologize if there are any issues in this pull request. Let me know if any issues and I will correct them as soon as possible. Thanks!

boring-cyborg[bot] commented 4 years ago

Thanks for opening this pull request! Please check out our contributing guidelines.

AmitGujar commented 4 years ago

It works perfectly, however, I have a question. Is it possible to download photos without opening an external site?

EDIT - never mind, I fixed that.

boring-cyborg[bot] commented 4 years ago

Congratulations!, Your PR is labelled as hacktoberfest-accepted :rocket:

k-azadzoi commented 4 years ago

Oh okay! Sorry I just sat down to read your comments.

Sounds good!