AmitKumarDas / metac

It is metacontroller and more
Apache License 2.0
57 stars 16 forks source link

chore(examples): add dontpanic controller #121

Closed AmitKumarDas closed 4 years ago

AmitKumarDas commented 4 years ago

This commit showcases how metac controller behaves when CRD is not applied against the k8s cluster but the controller tries to use an instance of this CRD.

It is expected that the controller should not panic immediately & should provide root cause of the error. This is helpful since there can be cases where a CRD is missing but controllers try to use their instances without above knowledge.

Signed-off-by: AmitKumarDas amit.das@mayadata.io

AmitKumarDas commented 4 years ago

@grzesuav Have updated with the requested changes. Added same changes to hello-world examples as well.

grzesuav commented 4 years ago

@AmitKumarDas LGTM from my side :)

AmitKumarDas commented 4 years ago

:tada: This PR is included in version 0.2.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: