AmitKumarDas / metac

It is metacontroller and more
Apache License 2.0
57 stars 16 forks source link

Migrate from glog to another log solution? #134

Open floriankoch opened 4 years ago

floriankoch commented 4 years ago

glog is not maintained since 2016 , and e.g the kubernetes project itself migrated away They use klog now, seems like more or less a drop in replacement https://github.com/kubernetes/klog

Should metac migrate away from glog?

If yes, which log solution?

grzesuav commented 4 years ago

https://github.com/AmitKumarDas/metac/issues/110

grzesuav commented 4 years ago

adding as it would be good to have possibility to log in json for usage with elasticsearch

AmitKumarDas commented 4 years ago

klog should be drop in replacement. Integration tests have them already. I would vote for klog.

As per this example, it has all the fields needed to output in a structured format.

It will be great if community can experiment klog with json output & post the results here.

AmitKumarDas commented 4 years ago

As discussed, Integration Tests in metac was using klog. This PR makes use of klog with appropriate flags.