search

AmitKumarDas / metac

It is metacontroller and more
Apache License 2.0
57 stars 16 forks source link

expose fields of structure to aid in unit testing #145

Open AmitKumarDas opened 4 years ago

AmitKumarDas commented 4 years ago

Take for example following structure used in dynamic/clientset/clientset.go file

type Clientset struct {
  config           rest.Config
  discoveryManager *dynamicdiscovery.APIResourceDiscovery
  dynamicClient    dynamic.Interface
}

Above structure does not provide any solution for the packages that depend on above struct during this package' unit tests. It will be easier to test if these fields were public. Alternate way will be to expose an interface for each & every public method of this struct. However, it does not seem the most idiomatic way to do.