search

AmitKumarDas / metac

It is metacontroller and more
Apache License 2.0
57 stars 16 forks source link

add support to update attachments even when they are pending deletion #63

Open AmitKumarDas opened 5 years ago

AmitKumarDas commented 5 years ago

UserStory: As an infrastructure admin, I want my workload specific un-installer to uninstall all native Kubernetes resources, custom resources as well related custom resource definitions. I would like to delete the workload specific namespace & expect all associated pods, deployments, crds, custom resources (even with finalizers) get deleted.

Metac ignores reconciliation if attachment resource(s) is pending deletion. This issue tackles this limitation of Metac by proposing a suitable enhancement.

AmitKumarDas commented 5 years ago

This PR (https://github.com/AmitKumarDas/metac/pull/60) was committed recently to handle updating attachment resources even if these are pending deletion. However, it will be better to have this tunable declared in the specs of meta controller (i.e. API enhancement). This API enhancement should work during sync as well as finalize hooks.