search

AmitMY / grids

A grid comparison standard
81 stars 15 forks source link

FancyGrid update #9

Closed MikeTatsky closed 6 years ago

AmitMY commented 6 years ago

I found the problem. If you look at the build: https://travis-ci.org/AmitMY/grids/builds/397273879?utm_source=github_status

You can see that you put in export: true, while export really is a string array of what format you can export to (for example, ["CSV", "PDF"])

MikeTatsky commented 6 years ago

I am sorry. I just updated. Please try again.

P.S.: I am not super cool about pull requests.

AmitMY commented 6 years ago

No worries! All seem to check out, one last thing is run npm run render and push those changes. it will update the comparison table on the README

MikeTatsky commented 6 years ago

Sorely on my side I have this when run

Could not use "nc", falling back to slower node.js method for sync requests.
(node:9332) [DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated.
AmitMY commented 6 years ago

Weird, it's not even an error just a warning... I'll merge it and run render when I have time, can be more than a few days.

MikeTatsky commented 6 years ago

Thank you.