Amitbhave / flutter-simple-url-preview

Simple url preview package for flutter
https://pub.dev/packages/simple_url_preview
MIT License
32 stars 35 forks source link

simple_url_preview.dart error after updateing to a new flutter version #26

Open zalekbloom opened 1 year ago

zalekbloom commented 1 year ago

After updating to a new flutter version I got the error: C:/Users/hayor/AppData/Local/Pub/Cache/hosted/pub.dev/simple_url_preview-3.0.1/lib/simple_url_preview.dart:174:54: Error: The getter 'accentColor' isn't defined for the class 'ThemeData'.

I am not expert in flutter but this site: https://docs.flutter.dev/release/breaking-changes/theme-data-accent-properties#migration-guide says:

Code before migration: MaterialApp( theme: ThemeData(accentColor: myColor), // ... ); Code after migration:

content_copy final ThemeData theme = ThemeData(); MaterialApp( theme: theme.copyWith( colorScheme: theme.colorScheme.copyWith(secondary: myColor), ), //... )

It looks that 'accentColor' is not defined there anymore.

But maybe I am wrong - can you look into this problem?

Thanks, zb

Amitbhave commented 1 year ago

Yes, you are right. The plugin is not yet migrated to Flutter 3.0. We will have to migrate to 3.0.

zalekbloom commented 1 year ago

Can you let me know when your migration is ready?

Thanks,

zb


From: AmitB @.> Sent: Monday, March 13, 2023 2:30 AM To: Amitbhave/flutter-simple-url-preview @.> Cc: zalekbloom @.>; Author @.> Subject: Re: [Amitbhave/flutter-simple-url-preview] simple_url_preview.dart error after updateing to a new flutter version (Issue #26)

Yes, you are right. The plugin is not yet migrated to Flutter 3.0. We will have to migrate to 3.0.

— Reply to this email directly, view it on GitHubhttps://github.com/Amitbhave/flutter-simple-url-preview/issues/26#issuecomment-1465584385, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIP3YIGANSLDDBC2PHAB4H3W325INANCNFSM6AAAAAAVYPF6V4. You are receiving this because you authored the thread.Message ID: @.***>

EtcGonza commented 1 year ago

Same issue here.