Set image fit to cover - Githubissues

Amitbhave / flutter-simple-url-preview

Simple url preview package for flutter

https://pub.dev/packages/simple_url_preview

MIT License

32 stars 35 forks source link

Closed paurakhsharma closed 4 years ago

paurakhsharma commented 4 years ago

Hey! Thank you for the awesome package.

I think the image with fill property looks weird for some images. So, I think it is better to use cover instead of fit.

Please let me know your thoughts.

Set image fit to BoxFit.cover so that image does not get stretched.

Github demo

Amitbhave commented 4 years ago

Thanks @paurakhsharma for your contribution! Will make it available in next release..

paurakhsharma commented 4 years ago

Awesome thank you for merging it. Any expected date for the release?

Amitbhave commented 4 years ago

@paurakhsharma will do it in a couple of days. Do you use this in some production app?

paurakhsharma commented 4 years ago

@Amitbhave Yeah, the app should go into production in 2 weeks.

Amitbhave commented 4 years ago

Wow! Sure will make it available today only then!

paurakhsharma commented 4 years ago

Wow! Thank you so much 😊