search

Amjad50 / plastic

NES emulator in rust with egui and TUI
MIT License
299 stars 12 forks source link

Potential Memory Leaks with File Explorer #19

Closed silverhadch closed 17 hours ago

silverhadch commented 1 day ago

The FileExplorer::with_theme(theme).unwrap() could leak memory if the theme object or internal state is not properly managed.

Review how FileExplorer handles its internal state and ensure that resources are properly cleaned up when the explorer is closed or destroyed.

Amjad50 commented 1 day ago

I really not sure what you mean by leaking here, the FileExplorer is used throughout the app lifetime, we just control if we render it or not, the object isn't destroyed, so nothing is leaked.

silverhadch commented 17 hours ago

Yes i didnt look at the entire Codebase just the TUI.