search

AmmarAbouZor / tui-journal

Your journal app if you live in a terminal
https://crates.io/crates/tui-journal
MIT License
401 stars 12 forks source link

Added: Colored Tags #455

Closed AmmarAbouZor closed 2 months ago

AmmarAbouZor commented 2 months ago

This PR adds the option to make the tags of the journals with different colors. Currently the colors are hard coded in the file tui-journal/src/app/colored_tags.rs and it's still not possible to assign colors to a specific tag.

This option can be disabled from the configuration be setting colored_tags = false, and it will be enabled by default.

This is the first step in the implementation for #407. After this PR we still need a way for the users to customize the colors and assign them to specific tags + We need to save this configuration in each project with option to export/import them.

@orhun I've tried to choose colors that should be easy to read on most of the famous colorschemes. But please feel free to open a PR with changes to the colors if you find any of them hard to read. The colors are in file tui-journal/src/app/colored_tags.rs

orhun commented 2 months ago

Hey, thanks for the implementation, works like a charm! Just two things:

AmmarAbouZor commented 2 months ago

Hey @orhun, thanks for the feedback!

  • The gray background color is not looking that great, I can submit a PR to change it :)

I think you can move it to the top of the list, so it will be picked last. You are welcome to change its colors and add additional colors as well.

  • What do you think of adding a special key binding for easily filter and toggle through labels? (instead of going to the filter menu and selecting the label manually)

I think we can add a keybinding to cycle through the lable tags, which will should create a filter with the first label if no filter exists, in other case it will cycle through the labels within the filter. But since there is still no way to configure this behavior is will be limited to cycle one tag at a time in a kind of arbitrary order. Please open another issue for this feature and feel free to add your suggestions for it :wink:

orhun commented 2 months ago

I tried different color combinations but they didn't work nearly as good as gray, so let's just keep it :)

Please open another issue for this feature and feel free to add your suggestions for it

I went ahead and implemented it :) #458