World doesn't load due to "invalid player data" if shop.csv is formatted incorrectly. Would be nice if the mod printed warnings on-screen instead of saying a generic "invalid player data".

AmmoniumX / AdminShop

Admin Shop Minecraft Mod

GNU Lesser General Public License v2.1

4 stars 4 forks source link

World doesn't load due to "invalid player data" if shop.csv is formatted incorrectly. Would be nice if the mod printed warnings on-screen instead of saying a generic "invalid player data". #11

Closed vizthex123 closed 1 year ago

vizthex123 commented 1 year ago

I fixed it by removing the errored line, but wanted to report this just in case - and suggest that it'd be nice if shop.csv disabled itself when loaded with errors (and printed a warning in chat when you loaded the world). I spent ~10 minutes trying to fix this before realizing it was AdminShop causing the issue.

Log: latest.log

AmmoniumX commented 1 year ago

The shop usually does disable itself when there's wrong formatting, please provide steps to replicate the bug (such as the shop.csv file and any additional steps)

vizthex123 commented 1 year ago

The shop usually does disable itself when there's wrong formatting, please provide steps to replicate the bug (such as the shop.csv file and any additional steps)

ah, sorry. Here's the file i used: shop.csv

all i did was enter my world and it gave me the error. I'm pretty sure making a new world didn't fix it either, but removing the goat horn entry fixed it.

AmmoniumX commented 1 year ago

Fixed as of v1.12