search

AmmoniumX / AdminShop

Admin Shop Minecraft Mod
GNU Lesser General Public License v2.1
4 stars 4 forks source link

EMI recipe tree integration #26

Closed sanyaysan closed 11 months ago

sanyaysan commented 11 months ago

Is your feature request related to a problem? Please describe. Adding a recipe from the shop into the EMI recipe tree is not working

Describe the solution you'd like Integration of adminshop with EMI could allow for displaying money values of items in recipe tree

Screenshots shop_EMI_integration

To Reproduce Steps to reproduce the behavior:

  1. Go to recipe for any item that can be bought in the shop via the recipe tree
  2. Click on item to buy in shop (red arrow)
  3. Recipe is not added to recipe tree. Selected item in corner dissapears (black arrow).

If this requires a complete restructure of the recipes it is probably not worth it, but maybe after a few hints/discussion I can take a crack at implementing this

sanyaysan commented 11 months ago

Upon further thought, this would require something like a "money item" -> "bought item", which would be really confusing and an unnecessary complication. I do really like the idea of displaying the shop recipes in EMI though, so let me know what you think.

AmmoniumX commented 11 months ago

Yeah, I think this wouldn't really be very viable, as having to create a money "item" for recipes would not work for values higher than 64. I think the "solution" is just to treat the bought items as the raw inputs