AmmoniumX / AdminShop

Admin Shop Minecraft Mod
GNU Lesser General Public License v2.1
4 stars 4 forks source link

`adminshop remove` returns generic error for insufficient funds #37

Closed James103 closed 2 months ago

James103 commented 2 months ago

Is your feature request related to a problem? Please describe. Since 0b7697036d747c1f47088bc9e3188165f53847e7 (when the command was implemented), the message received when removing money from an account through a command is a generic "Error removing money from account," even if the error is specifically caused by insufficient funds.

To reproduce, just run adminshop remove {owner} {id} {amount} with {amount} high enough such that there is insufficient funds in the account specified by {owner}:{id} to deduct the entire {amount}.

Describe the solution you'd like In that case, return a more specific error message: "Insufficient money in account" or "Not enough money in account"

Describe alternatives you've considered A wrapper can be constructed which uses the return value (the value stored by execute store result) and displays the specific insufficient money message in case of an error.