AmmoniumX / AdminShop

Admin Shop Minecraft Mod
GNU Lesser General Public License v2.1
4 stars 4 forks source link

Several suggestions #8

Closed vizthex123 closed 1 year ago

vizthex123 commented 1 year ago

I personally use the 1.19.2 version of the mod, but having these on all versions would be nice.

If I think of anything else, I'll add it here.

AmmoniumX commented 1 year ago

First and fourth point is referenced in #7 Second point was fixed in 2f7fbbbde562163d720cf55349459a563209a496 . For the third point, I'm not going to make each permit a different item and define it in mod config because that could get too bloated and much more difficult to handle for modpack makers/server admins that have a LOT of permits, for example if they want every item to have a different permit. "Fiddling with NBT data" isn't really difficult if you know how to do it, it exists for a reason and this is an appropriate use for it. For the final point, I am not sure what advantage bringing custom Rarity would bring, it seems like a rarely-used feature, and it's not able to be done via NBT, an item can only have one "base" rarity, and only enchanting can "upgrade" this rarity, so it's not planned