search

Amna-Hassan04 / Serenity-Guide

SereniFi Guide is a personalized relaxation app offering meditations, breathing exercises, and calming music to help users achieve mental tranquility.
https://serenify.streamlit.app/
Other
33 stars 90 forks source link

Added detailed instruction for Guided breathing #200

Closed shrehs closed 1 week ago

shrehs commented 3 weeks ago

Closes: #199 Added detailed instruction for guided breathing

Screenshot (142) Screenshot (143)

Working video: Guided_breathing.webm

zoobiasyed commented 3 weeks ago

@Amna-Hassan04 kindly look into this, @shrehs has provided us with necessary pictures and a working video. If you feel like it’s complete, merge it asap.

shrehs commented 3 weeks ago

@zoobiasyed and @Amna-Hassan04 #199 issue hasn't been assigned labels yet, could you please look into it

zoobiasyed commented 3 weeks ago

@Amna-Hassan04 kindly add labels to issue #199.

shrehs commented 2 weeks ago

Hey! Cool. Will add longer instructions. If you could provide an example on what you are looking I would be glad to work on it also I wanted to ask on integrated part. I have added the code as part of app.py, you can check this in file changed in the PR raised. could help me understand if I have to integrate it somewhere else... Thank you

zoobiasyed commented 2 weeks ago

@Amna-Hassan04 can you provide @shrehs with a sample writing? That would make her task easier and it would be in accordance with our requirements.

zoobiasyed commented 1 week ago

@shrehs your pr will only be merged if all the relevant details and pictures are mentioned. Also all the test cases should be passed, before the deadline.

Amna-Hassan04 commented 1 week ago

@shrehs I myself dont know about box breathing this was a task that u wanted to work on, but this implementation isnt really helping the user, bcz If i were to follow this I wouldnt be able to. the aesthetic doesnot match the projects appeal if i were u i would just find a video online and embed it like the one on teh first page of the, if u want to make any changes do it before 7 pm after that the gssoc leaderboard will close, Thanks.

Amna-Hassan04 commented 1 week ago

@shrehs for now Im closing this pr as this is not relevant if u implement the above points plz raise a pr again before 7 pm, I will review it and merge it if applicable.