search

Amndeep7 / ptw-extender

Extension that adds titles to your MyAnimeList, AniList, or Kitsu plan-to-watch/read list with the url of where you found the title added as a comment.
Other
10 stars 0 forks source link

Settings page #16

Open Amndeep7 opened 5 years ago

Amndeep7 commented 5 years ago

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Implement_a_settings_page

Amndeep7 commented 5 years ago

Ideas for settings will also be left here as a permanent issue for now I guess

Amndeep7 commented 5 years ago

~Notifications on/off~

Should be taken care of by 98040fd

MERGED

Amndeep7 commented 5 years ago

~#15 and the comments within~

MERGED: https://github.com/Amndeep7/ptw-extender/commit/38cc9685e3d901db7e20278076b2d5265364d374

Amndeep7 commented 5 years ago

11

Amndeep7 commented 5 years ago

~which search engine for #9 if more than one is feasible~

As of right now, the only reasonably feasible one is AniList's search in terms of minimal amount of requests needing to be made and size of library

WONTADD

Amndeep7 commented 5 years ago

~#12 - on by default~

Should be taken care of by b47b69e3bbbe364f167f778b5fa5dd2d93805f78 for MAL

MERGED: https://github.com/Amndeep7/ptw-extender/commit/5b9a7a2e154eee45abe6f9689f19eaa4984c37e2

Amndeep7 commented 5 years ago

~On/off setting per list site - all the settings that are site dependent can be dependent on that. Also send notification if site is recognized but site is turned off.~

Should be taken care of by 98040fd and 6bfc839

MERGED

Amndeep7 commented 5 years ago

~Whether or not to add the tab url to the comments box~

This is supposed to be the key draw to the extension besides the right-click to add to ptw

WONTADD

Amndeep7 commented 5 years ago

~Anilist allows custom lists, allow the user to specify which list they want it inserted in, but default to planning/plan to watch/whatever they're calling it~

~Edit: Looks like you have to have a status/list and then can also put it in 1 or more customlists and if you do so, then you can hide it from the status-lists. Looks like you can also make them private from others. So looks like 3 settings: 1) list of customlist names (drop down list and press a button to make another appear? all of them and then checkboxes?), 2) checkbox for hide from status-lists that's dependent on if any of the customlists are selected, 3) checkbox for privacy~

~Edit 2:~ ~if you don't have any custom lists, then the hide from status lists checkbox doesn't appear in the list editor popup on the website; if you do have some custom lists, then that hide from status lists checkbox does appear and lets you check it even if you don't add the entry to a custom list; if you then check your profile, that entry is not in any of your lists if you didn't add it to a custom list when you checked the box for hiding them from the status lists~ ~In other words, the website seems kinda buggy in this regard, but the api doesn't have any such dependency issues so all three of the above settings should be completely independent of each other~

MERGED: 976cd81dce5c4f61606d3fd966c9b163855098c4