search

Amndeep7 / ptw-extender

Extension that adds titles to your MyAnimeList, AniList, or Kitsu plan-to-watch/read list with the url of where you found the title added as a comment.
Other
10 stars 0 forks source link

Context menu doesn't show up #19

Closed Amndeep7 closed 5 years ago

Amndeep7 commented 5 years ago

Supposedly the browser.runtime.OnInstalled listener wrapper should have been sufficient to make sure that the context menu always shows up, but that was not the case for some reason (FF on Win10). Reinstalling the add-on made it work fine, which makes sense cause it'll definitely hit the oninstalled event then, but apparently there might be some event that happens where the browser starts up without this event having fired so the context menu never gets loaded in. I'll just buck what appears to be the supposedly accepted practice of having that wrapper and instead just on every load of the extension, I'll make it so that all the contextmenus get removed and then I add in my little guy again.

Example of best practice that doesn't always work out :(

Example of hackier practice that I think will be more consistent at the expense of a few cpu cycles on the part of the user.

Amndeep7 commented 5 years ago

Solved with https://github.com/Amndeep7/ptw-extender/pull/20