Added Distance Units for the scale widget, parametrised QT version.

AmonRaNet / QGeoView

QGeoView is a Qt / C ++ widget for visualizing geographic data.

GNU Lesser General Public License v3.0

155 stars 60 forks source link

Added Distance Units for the scale widget, parametrised QT version. #21

Closed raffmont closed 2 years ago

raffmont commented 2 years ago

The Scale widget has been enhanced with three distance units: kilometers, nautical, and miles. For each distance unit, it is possible to choose if using meters for small distances (less than 1km, less than one nautical mile, less than 1 mile). The CMakeLists.txt files in the demo and lib have been changed, enabling the developer to choose the QT version manually.

AmonRaNet commented 2 years ago

Generally looks fine for me. Good job!

One behavior comment is: mUseMetersForSmallDistance I think make sense to apply only for meter unit and ignore for all other units (if we not plan to apply yards or something like this).

Also before merge I will apply some formatting changes and other changes to follow project style.

AmonRaNet commented 2 years ago

PR merged with fixes:

formatting
Units enum moved to QGVGlobal
Helper functions added (meter to unit, unit to string) - can be reused in other places also
QT selection done over cached variable, default Qt6 if exists

Thanks for good job!