"SHAPE GEN" problems with input WH (VEC2)

[Maelstrom2014]

Here the problem https://ibb.co/vqYy7ZQ please tell if its a bug or smth not right with my installation?

[Amorano]

So, I dont know what a "compose vec2" node is -- I have no translation for whatever that is making -- which it looks like its making an "array" of numbers not a tuple [[x], [y]] not (x, y).

I will check if I can make a translation for the ComfyMath extension node (I do not use that -- my repo does all that -- use a value node). Same for all the math operations:

[Amorano]

so, looking at that node, it makes a LIST not a TUPLE -- so it is seeing the X as one entry and Y as another and making a tensor batch of (2).

I cant really fix this as its a problem in the ComfyMath node itself since it is pushing out a list [x, y] and not a list of coordinates [[x, y]]*

p.S. I actually have an idea to make this work... brb =D

[Maelstrom2014]

BTW, OLD "SHAPE GENERATOR" worked ok with VEC2, after update my WF not work anymore, that I need to rebuild it. Tried to find commit with that edition, but fail to find. May be you can help?

[Amorano]

BTW, OLD "SHAPE GENERATOR" worked ok with VEC2, after update my WF not work anymore, that I need to rebuild it. Tried to find commit with that edition, but fail to find. May be you can help?

Correct, because I was not working the proper way in Comfy. ComfyUI treats all lists as a list. If you want to make things like "coordinates" work you should use a dict {x:0, y:0} or a list of "list" or "tuple" [(x, y)] -- otherwise no one can tell if you are sending in coordiantes or just a number line. 0, 1, 2, 3,, 5....

I had an idea to try and hackish around getting the output type from the ComfyMath slot, but it is more work than it needs to be.

I have only just started doing documentation; hopefully some videos and more workflows too soon.

the image of the workflow you posted doesnt look like it would be much work to convert. If you want to post another screenshot or a workflow that you want to see get translated, I can try to help speed that up for you.

[Maelstrom2014]

Another Question, If I make input form node "VALUE JOV", queue not starting.

Im makein a range, and want SHAPE GEN animate moving rectangle.. With new version its not working. in WH I put static frame size, and in XY I put a range of moving Y.

New version of whis NODE have problems with ranges? thats a screenshot: https://ibb.co/hXR3yZG

[Amorano]

Another Question, If I make input form node "VALUE JOV", queue not starting.

Im makein a range, and want SHAPE GEN animate moving rectangle.. With new version its not working. in WH I put static frame size, and in XY I put a range of moving Y.

New version of whis NODE have problems with ranges? thats a screenshot: https://ibb.co/hXR3yZG

take this image and drag it into comfy (it has the workflow). If that doesnt work, then yeah there maybe a problem; however, in your screen shot it has the output in the Akashic (that means it ran) -- you dont have it actually plugged into anything IN the shape generator node.

[Maelstrom2014]

Another Question, If I make input form node "VALUE JOV", queue not starting. Im makein a range, and want SHAPE GEN animate moving rectangle.. With new version its not working. in WH I put static frame size, and in XY I put a range of moving Y. New version of whis NODE have problems with ranges? thats a screenshot: https://ibb.co/hXR3yZG

take this image and drag it into comfy (it has the workflow). If that doesnt work, then yeah there maybe a problem; however, in your screen shot it has the output in the Akashic (that means it ran) -- you dont have it actually plugged into anything IN the shape generator node.

I mean input (when I convert a x and to in widget input) to VALUE JOV node. I try to make it form a right value for inputing to SHAPE GEN. (like on my picture)

[Maelstrom2014]

Problems 1): Can you start this work flow? I can not.

[Amorano]

ok! thank you for the clear example. I cleaned up a few things in the defaults for the shape node and a few others, and re-wired the value node a bit to be more clear with the inputs vs. defaults.

You wont have to convert a widget anymore -- just plug in your default. The widget value will be used as a default if there is no input and its a value that can be used in the output.

I will do some more testing and push the changes in tomorrow.

Thank you for the bug report!

[Amorano]

ran through some tests and went back to check the original use-case. Seems to have cleaned all that messy stuff up.

You can see here you can now also just use a single float, int, etc... and the remaining values will self-populate based on the last value, or an override default. All the fall through values!

Let me know if you find any weirdness -- and any other use-cases with other 3rd party nodes -- I will try to accommodate any translators for their type(s).

HTH

[Maelstrom2014]

thanx for fixes! I'll try tomorrow how it inputs a ranges of numbers. Did you test it?

[Amorano]

thanx for fixes! I'll try tomorrow how it inputs a ranges of numbers. Did you test it?

Do you mean with batches? Works as it should -- seems good.

[Maelstrom2014]

HI, again! I updated with "git pull" today. May be I need delete and reinstall? Cant check updated. Here is two problems: 1) parameter of shape points not visible by default. 2) Cant converts widget (ex WH or XY) to outer input

[Amorano]

HI, again! I updated with "git pull" today. May be I need delete and reinstall? Cant check updated. Here is two problems:

1. parameter of shape points not visible by default.

2. Cant converts widget (ex WH or XY) to outer input
   ![prob2](https://private-user-images.githubusercontent.com/10183119/336073963-

On no!

So for the first one, you dont see that parameter unless you change the shape -- the sides are only visible for the POLYGON type.

The second one looks like a bug, 100%. I have patched that up and will push it shortly.

Thank you again. I checked a few more nodes from the packs you are using to make sure things work back and forth for list/single values.

Cheers!