Amorano / Jovimetrix

ComfyUI node suite for composition, stream webcams or media files in and out, animation, flow control, making masks, shapes and textures like Houdini and Substance Designer, read MIDI devices. Also has colorization options for workflow nodes via regex, groups and each node.
Other
240 stars 20 forks source link

JOV Blend compability with Mixlab #49

Closed kakachiex2 closed 1 month ago

kakachiex2 commented 1 month ago

Hi Amorano, I'm building a workflow to emulate photoshop blend mode effects with layer and I'm using your JOV Blend node with Mixlab layer node but I'm getting empty result can you make your node compatible with mixlab layers node it will be helpful and useful. workflow (1)

Amorano commented 1 month ago

I will check it out! If the layers are images, then it should work same as if you plug in any image. If the layers some special type I will need to make a conversion node or perhaps add a new output just for that type =D

Cheers for the idea!

kakachiex2 commented 1 month ago

Thanks Amorano, I will keep an eye on this I want to create a production mockup logo placement similar to photoshop with shadow layer and lighting layers I think it can be done with those node.

kakachiex2 commented 1 month ago

Here is the full workflow if you want to give it a check. Logo Placement Mockup experiment

kakachiex2 commented 1 month ago

Need a lot of work to be production ready, if you can give me some feedback would be nice and thanks for your excellent tools

Amorano commented 1 month ago

Need a lot of work to be production ready, if you can give me some feedback would be nice and thanks for your excellent tools

Just so I understand the workflow(s)... You are looking to do normal alpha blend compositing?

image

like in the image? I am looking at the mixlab stuff now, but it seems you may not need a lot of the layering if you just slap composite as you go i.e. 2 layers in, one layer out into 2 layers in, etc...

kakachiex2 commented 1 month ago

In photoshop to achieve the shadowing and lighting effects over flat color and logos or design you need:

kakachiex2 commented 1 month ago

Here is the image if you need testing: Hoodie_Lighting Hoodie_Shadow

kakachiex2 commented 1 month ago

The dark Hoodie is the lighting layer, and the white Hoodie is the shadow layer.

kakachiex2 commented 1 month ago

Everything : Flat color mask to color the hoodie | Logos placement, design goes under those two layer to achieve the volumetric shadow and light effects.

kakachiex2 commented 1 month ago

This is an example of how it looks like are under the shadow and light layer, this is in photoshop. 441462882532+7188658323684+3

kakachiex2 commented 1 month ago

This is the final Workflow module for this part of the completed Workflow, looks like the blend mode is not parsing throw the layers because is supposed to get the solid color mask layer in the last layer. I upload the mask layer if you need it. Hoodie_FullMask

Emulate PS-BlendMode_ShadowLight

Amorano commented 1 month ago

In photoshop to achieve the shadowing and lighting effects over flat color and logos or design you need:

* one layer with the shadow in linear burn blend mode
* another one on top the shadow layer in screen blend mode

image

image

image

Latest push has the changes!

I have added support to pass through layers as "images".

You can see in image 2 and 3 that mixlab is performing some type of blend/anti-aliasing. Just keep that in mind, as I also see a color shift in the mixlab nodes.

Let me know if that resolves this request!

cheers!

kakachiex2 commented 1 month ago

Thanks, Amorano, let me test it. But keep in mind the only way to know if it working is using the shadow and light layer flat color are not good for this testing.

kakachiex2 commented 1 month ago

Looks like the blend mode is working but not properly, the flat color mask under the shadow and light layer looks dull it supposed to looks like this image. Here is an example comfyui and PS maybe a problem with Mixlab layer don't pass blend mode correctly. BlendMode-01 BlendMode

kakachiex2 commented 1 month ago

This could be a great layer system for ComfyUI more efficient than the others implementation, but this is only a mockup idea. ComfyUI Layer Stack node-01

Amorano commented 1 month ago

Unfortunately, making an entire layer compositing system like that requires time and I sadly do not have a job, so, that is a pipe dream idea for me. I will say, if I ever get sponsors, or a studio job (ever again) I will 100% invest into the idea you have above.

That said, I feel you are over-complicating your setup.

image

feels like it does the same thing you want, with no mussing in wacky layer stacks.

As for the blend node not working "properly" it is 100% working properly =D

The blend node is using the blend modes library* to do the actual blends, all being done in sRGB space.

As mentioned previously there is something in Mixlab that is anti-aliasing and changing the color space on the images. You can see that yourself plugging in a single image to a layer and rendering the layer with no changes back to an image.

kakachiex2 commented 1 month ago

This setup work excellent if only for coloring the cloth but how do I add the lighting effects, The setup I post work excellent the only problem is dull appearance, another think is this is only a small part of the whole workflow is really big and more complicate. Thanks for your help I will continue testing and experiment to see how to solve this problem, your node work excellent I test it combined with others node.

Amorano commented 1 month ago

Looks like the blend mode is working but not properly, the flat color mask under the shadow and light layer looks dull it supposed to looks like this image. Here is an example comfyui and PS maybe a problem with Mixlab layer don't pass blend mode correctly.

image

just for completeness. I posted (similar) in the discord as well.

I hope that helps a bit in either case!

Cheers

kakachiex2 commented 1 month ago

This last setup looks interesting I will check wen I have time