Amorano / Jovimetrix

ComfyUI node suite for composition, stream webcams or media files in and out, animation, flow control, making masks, shapes and textures like Houdini and Substance Designer, read MIDI devices. Also has colorization options for workflow nodes via regex, groups and each node.
Other
260 stars 22 forks source link

Error on Console After New Update: create_glsl.py and enum.py #56

Closed Orenji-Tangerine closed 1 month ago

Orenji-Tangerine commented 1 month ago

image

module failed A:\ComfyUI\custom_nodes\Jovimetrix\core\create_glsl.py cannot import name 'EnumType' from 'enum' (A:\ComfyUI\python\lib\enum.py)

Works fine under commit 54d61c3

Amorano commented 1 month ago

Are you sure you are on the latest commit? There is no import for Enum in that file.

Amorano commented 1 month ago

image

module failed A:\ComfyUI\custom_nodes\Jovimetrix\core\create_glsl.py cannot import name 'EnumType' from 'enum' (A:\ComfyUI\python\lib\enum.py)

Works fine under commit 54d61c3

image

The commit you reference is several pushes behind. Please make sure to update to the latest.

Orenji-Tangerine commented 1 month ago

Yes, what I mean is that when I update it to the latest version, the above error prompts on the console screen during the startup.

Amorano commented 1 month ago

What exact version of python comes up in your console?

https://docs.python.org/3/library/enum.html#enum.EnumType

Is a standard python library. My first concern is the origin of the error as the create-glsl file doesnt import EnumType itself.

Also please report the comfy version and the frontend version * (those should be in your log)

Orenji-Tangerine commented 1 month ago

What exact version of python comes up in your console?

https://docs.python.org/3/library/enum.html#enum.EnumType

Is a standard python library. My first concern is the origin of the error as the create-glsl file doesnt import EnumType itself.

Also please report the comfy version and the frontend version * (those should be in your log)

My Python is 3.10.11 image

I have also uninstalled and reinstalled the node, and it is the same.

Comfy version from the log file ComfyUI Version: bc94662b31351ac3ccde903c3829e5abce3d7b6f (2024-09-10 12:43:37)

It should be commit bc94662

Orenji-Tangerine commented 1 month ago

image

Orenji-Tangerine commented 1 month ago

It is probably due to Comfy version I am using? But anyway it does not show error with commit: 54d61c3

Amorano commented 1 month ago

Your python version is 3.10.

Even the older versions I made (from 10 months ago) all target python 3.11.

EnumType is a fundamental type that should be in your embedded python (even for 3.10).

I would double check that your comfy is correct and up-to-date.

I will leave this open but I tried various setups today and could not reproduce this behavior.

Amorano commented 1 month ago

image

Some versions to check.

Orenji-Tangerine commented 1 month ago

Maybe probably due to using Python 3.10, I could not locate a similar frontend directory. I am using a ComfyUI launcher from Aki due to ease of updating nodes, so maybe I will stick to the working commit first, in the meantime I will update my launcher environment.

image

Amorano commented 1 month ago

ok, so if you are using someone else's launcher with their supports, I cant really support that. Sorry, I only support the official comfyui main branch.

I would try to use the official repository, its not that hard, and will keep you current with everything proper.

Orenji-Tangerine commented 1 month ago

Anyway, just to confirm that it only happens on Python 3.10, I have tried using 3.11/3.12 and this issue doesnt happen...

Orenji-Tangerine commented 1 month ago

Python 3.10 works again from commit ed67ec5

Amorano commented 1 month ago

Python 3.10 works again from commit ed67ec5

HA! Yes, you can 100% thank VykosX for making the convincing argument for a single line change since everything already worked for 310 =D

I would support 310 except I try to keep to the VFX Platform as much as I can, but, this seems like a no brainer fix to keep it supported.

Sorry for any time resources wasted!