search

Amorano / Jovimetrix

ComfyUI node suite for composition, stream webcams or media files in and out, animation, flow control, making masks, shapes and textures like Houdini and Substance Designer, read MIDI devices. Also has colorization options for workflow nodes via regex, groups and each node.
Other
240 stars 20 forks source link

Stream Reader Broken? #9

Closed thot-experiment closed 9 months ago

thot-experiment commented 9 months ago

image Not sure when this broke, I'll try to investigate further, but in case I don't, this is the error I'm getting for this two node graph. I was previously able to stream my webcam to comfy using the same approach. Has the device selection method changed, do I need to do something differently or is this actually a bug?

za-wa-n-go commented 9 months ago

There are no errors, but I am still unable to capture from the camera.

Amorano commented 9 months ago

This is resolved in the latest push. Make sure you are using only a single instance on the same "URL". Also note you need to now explicitly put in the device #. I have the default at 0, but that may not be the default for your your system(s) camera(s).

please re-open if it is failing in the same way.

za-wa-n-go commented 9 months ago

IMPORT FAILED

Traceback (most recent call last): File "C:\Product\ComfyUI\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1810, in load_custom_node module_spec.loader.exec_module(module) File "", line 940, in exec_module File "", line 241, in _call_with_frames_removed File "C:\Product\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\Jovimetrix__init.py", line 861, in session = Session() ^^^^^^^^^ File "C:\Product\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\Jovimetrix__init.py", line 129, in call instance = super().call__(*arg, **kw) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Product\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\Jovimetrix__init.py", line 238, in init__ module = importlib.import_module(f"Jovimetrix.nodes.{f.stem}") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "importlib\init__.py", line 126, in import_module File "", line 1204, in _gcd_import File "", line 1176, in _find_and_load File "", line 1147, in _find_and_load_unlocked File "", line 690, in _load_unlocked File "", line 936, in exec_module File "", line 1074, in get_code File "", line 1004, in source_to_code File "", line 241, in _call_with_frames_removed File "C:\Product\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\Jovimetrix\nodes\device.py", line 242 StreamManager(). ^ SyntaxError: invalid syntax

Amorano commented 9 months ago

Sorry, there was a literal copy-pasta in the file just before the commit. You should be good.