Some fixes in Diff command.

AmpScm / SharpSvn

Subversion wrapped for .Net 4.0+ and .Net Core

Apache License 2.0

58 stars 19 forks source link

Some fixes in Diff command. #97

Open rinrab opened 5 months ago

rinrab commented 5 months ago

This pull-request does little fixes in the Diff command.

Use newer Subversion API possibilities to do diff in one thread. The SvnStreamWrapper is already used in the Write command, while diff was used the AprStreamFile.
Use Null Stream (System::IO::Stream::Null) instead of creating new MemoryStream if no ErrorSteam are set. This is needed to prevent creation a new MemoryStream on every diff invocation.

rhuijben commented 5 months ago

Subversions diff can be rerouted to an external diff command. This command only works properly if there is really a file handle behind the stream. (Subversions obtains the backing handle via a private Api in this case)

rinrab commented 5 months ago

Does SharpSvn support an external diff command? Because, as I found, the diff cmd property resets in the SvnClientContext::ApplyUserDiffConfig() function.

Could I solve the problem by adding check of diff_cmd for null and use different streams based on this?

rhuijben commented 5 months ago

Sure, if you check for the safe case then we can go this route.

rinrab commented 5 months ago

I think I am done with implementation of the check for diff_cmd. Could you please review these changes?

Thanks!

rinrab commented 4 months ago

@rhuijben Did you see my new commits?