AmpersandHQ / ampersand-magento2-upgrade-patch-helper

Helper script to aid upgrading magento 2 websites by detecting overrides. Now supports third party module detections
GNU Lesser General Public License v3.0
322 stars 39 forks source link

Add 'meaningful' checks to php #114

Closed convenient closed 1 year ago

convenient commented 1 year ago

Part of #110

We do not look for "redundant" overrides as with class names etc it can be quite hard. We'll filter out comments/whitespace etc which should do a good job anyway. (This is inline with the issue as it was raised https://github.com/AmpersandHQ/ampersand-magento2-upgrade-patch-helper/issues/85)

For ignoring non-meaningful changes these are split into two groups

For example

| IGNR  | Preference               | vendor/ampersand/upgrade-patch-helper-test-module/src/module/Model/ToPreferenceAndIgnore.php                                       | Ampersand\Test\Model\ToPreferenceAndIgnore                                                                                         |

In this case vendor/ampersand/upgrade-patch-helper-test-module/src/module/Model/ToPreferenceAndIgnore.php had some whitespace/comment style change, and theres no need to report you have a preference of Ampersand\Test\Model\ToPreferenceAndIgnore defined.