Closed convenient closed 1 week ago
@tr33m4n I don't know if Travis is not initiating jobs from pull requests. But worth testing with 8.3 and 2.4.7-p3 for the latest GitHub issue
@convenient Both m24 and m24nodb jobs failed with:
docker exec -e PHPUNIT_ARGS='''' -it uphelper-m24 ./dev/Docker/run-phpunit-functional-tests.sh
PHPUnit 9.6.4 by Sebastian Bergmann and contributors.
Test 'FunctionalTests::testMagentoTwoFour' started
Test 'FunctionalTests::testMagentoTwoFour' ended
Generated command: php /src/bin/patch-helper.php analyse --pad-table-columns 130 --sort-by-type --vendor-namespaces Ampersand --php-strict-errors /src/dev/instances/../instances/magentom24
Test 'FunctionalTests::testMagentoTwoFourVirtualPlugin' started
Test 'FunctionalTests::testMagentoTwoFourVirtualPlugin' ended
Generated command: php /src/bin/patch-helper.php analyse --php-strict-errors /src/dev/instances/magentom24
Time: 00:54.407, Memory: 6.00 MB
There was 1 failure:
1) FunctionalTests::testMagentoTwoFour
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
| WARN | Override (phtml/js/html) | vendor/magento/module-sales/view/frontend/layout/sales_order_print.xml | app/design/frontend/Ampersand/theme/Magento_Sales/layout/sales_order_print.xml |\n
| WARN | Override (phtml/js/html) | vendor/magento/module-ui/view/base/web/templates/block-loader.html | app/design/frontend/Ampersand/theme/Magento_Ui/web/templates/block-loader.html |\n
| WARN | Override (phtml/js/html) | vendor/magento/module-ui/view/base/web/templates/grid/masonry.html | app/design/frontend/Ampersand/theme/Magento_Ui/web/templates/grid/masonry.html |\n
+| WARN | Override (phtml/js/html) | vendor/magento/theme-frontend-blank/etc/view.xml | vendor/ampersand/upgrade-patch-helper-test-hyva-fallback-theme/theme/etc/view.xml |\n
| WARN | Override (phtml/js/html) | vendor/magento/theme-frontend-blank/etc/view.xml | vendor/ampersand/upgrade-patch-helper-test-module/src/theme/etc/view.xml |\n
| WARN | Override (phtml/js/html) | vendor/magento/theme-frontend-luma/Magento_Sales/email/order_new.html | vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Sales/email/order_new.html |\n
| WARN | Override (phtml/js/html) | vendor/magento/theme-frontend-luma/etc/view.xml | vendor/ampersand/upgrade-patch-helper-test-hyva-fallback-theme/theme/etc/view.xml |\n
@@ @@
| WARN | Redundant Override | vendor/ampersand/upgrade-patch-helper-test-module/src/module/view/frontend/email/redundant.html | app/design/frontend/Ampersand/theme/Ampersand_TestVendor/email/redundant.html |\n
| WARN | Redundant Override | vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Checkout/web/js/redundant.js | app/design/frontend/Ampersand/theme/Magento_Checkout/web/js/redundant.js |\n
| WARN | Redundant Override | vendor/ampersand/upgrade-patch-helper-test-module/src/theme/Magento_Ui/web/templates/redundant.html | app/design/frontend/Ampersand/theme/Magento_Ui/web/templates/redundant.html |\n
-| WARN | Redundant Override | vendor/magento/theme-frontend-blank/etc/view.xml | vendor/ampersand/upgrade-patch-helper-test-hyva-fallback-theme/theme/etc/view.xml |\n
| WARN | Redundant Override | vendor/paypal/module-braintree-core/view/base/web/js/form-builder.js | vendor/paypal/module-braintree-core/view/frontend/web/js/form-builder.js |\n
+-------+--------------------------+------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------------------------------------------------------------------------------+\n
WARN count: 63\n
-INFO count: 395 (to view re-run this tool with --show-info)\n
+INFO count: 396 (to view re-run this tool with --show-info)\n
IGNORE count: 7 (to view re-run this tool with --show-ignore)\n
For docs on each check see https://github.com/AmpersandHQ/ampersand-magento2-upgrade-patch-helper/blob/master/docs/CHECKS_AVAILABLE.md'
/src/dev/phpunit/functional/FunctionalTests.php:195
FAILURES!
Tests: 2, Assertions: 6, Failures: 1.
make: *** [Makefile:15: docker-test] Error 1
The command "make docker-test ENV=$TEST_GROUP" exited with 2.
cache.2
store build cache
Done. Your build exited with 1.
I might be able to take a look this eve
@tr33m4n gone green fyi
Update test cases to cover php 8.3 and magento 2.4.7-p3
Checklist