Fixes php warning about explode receiving NULL when no files could be… - Githubissues

AmpersandHQ / ampersand-magento2-upgrade-patch-helper

Helper script to aid upgrading magento 2 websites by detecting overrides. Now supports third party module detections

GNU Lesser General Public License v3.0

322 stars 39 forks source link

Fixes php warning about explode receiving NULL when no files could be… #95

Closed hostep closed 1 year ago

hostep commented 1 year ago

… found in a certain directory.

Ran into this warning while running the tool, because our app directory didn't contain any *.html files:

PHP Deprecated:  explode(): Passing null to parameter #2 ($string) of type string is deprecated in src/Ampersand/PatchHelper/Helper/Magento2Instance.php on line 461

Noticed that the same code was used for xml files, so fixed it as well over there.

Checklist

[x] Pull request has a meaningful description of its purpose
[x] All commits are accompanied by meaningful commit messages
[ ] Tests have been ran / updated

convenient commented 1 year ago

Thanks @hostep