search

AmpersandJS / amp

a collection of individual JS utility modules
http://amp.ampersandjs.com
MIT License
130 stars 12 forks source link

Replace next #67

Closed HenrikJoreteg closed 9 years ago

HenrikJoreteg commented 9 years ago

making tweaks per discussion on #64.

This replaces next with jump which works the same if using defaults, but is more configurable.

HenrikJoreteg commented 9 years ago

ugh, sorry for all the noise in this PR, since it has all the built stuff.

Biggest thing is reviewing doc, implementation and tests for jump starting here: https://github.com/AmpersandJS/amp/pull/67/files#diff-c3c914253380116fd0a2e7f0ea642b91R1

Also interested in input on the name and API. <3z

kamilogorek commented 9 years ago

Verified https://github.com/AmpersandJS/amp/pull/67/files#diff-c3c914253380116fd0a2e7f0ea642b91R1 + tests and it looks fine! jump naming is fine for me as well, as it describes exactly what it does, it jumps in one way or another. Plus it doesn't imply a direction.

aaronmccall commented 9 years ago

+1 on the api, name, and docs

fyockm commented 9 years ago

As @kamilogorek mentioned, jump makes more sense to me since it doesn't imply direction (vs next/prev). API and docs also look good to me.

HenrikJoreteg commented 9 years ago

Not sure how, but the travis CI hook had gotten disabled somehow. Anyway, re-installed it, seems to be running it.

HenrikJoreteg commented 9 years ago

@kamilogorek @aaronmccall @fyockm thanks everyone! Merged, published, and site-updated.