AmpersandJS / amp

a collection of individual JS utility modules
http://amp.ampersandjs.com
MIT License
130 stars 12 forks source link

swap `uglifyjs` for `uglify-js` #83

Closed fyockm closed 9 years ago

fyockm commented 9 years ago

uglifyjs was apparently unpublished: https://www.npmjs.com/package/uglifyjs

uglify-js is a more popular drop-in replacement.

fixes #82

fyockm commented 9 years ago

FWIW...tests actually do pass. I think "saucelabs" is on the sauce.

Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided.

kamilogorek commented 9 years ago

cc @bear

bear commented 9 years ago

@kamilogorek @fyockm - I've updated the master branch with the proper credentials

fyockm commented 9 years ago

thanks @bear. can you re-run travis on my last commit so it shows as passing?

Following that, can I get a +1 on this so it can be merged?

bear commented 9 years ago

@fyockm you will need to add the changes I made to .travis.yml to your PR

fyockm commented 9 years ago

@bear still failed?

bear commented 9 years ago

for whatever odd reason travis-ci is not showing the last commit in this PR so it's failing

wraithgar commented 9 years ago

OK builds are passing over in #84 give your +1's there please.