search

AmpersandJS / ampersand-collection

A module for handling collections of objects
MIT License
68 stars 27 forks source link

update testing framework, fix isCollection bug #74

Closed wraithgar closed 8 years ago

wraithgar commented 8 years ago

Switch fully to zuul Add saucelabs config Use node LTS and npm 2 for building

See discussion that led to this here: AmpersandJS/ampersand-filtered-subcollection#26

Setting isCollection as a value property meant that some browsers (phantomjs at least) were allowing it to be overwritten. Changed to a proper getter only.

This will warrant a new release, unlike most of the other PRs that are updating testing, as there was a change in the code itself.

kamilogorek commented 8 years ago

:ok_hand:

wraithgar commented 8 years ago

travis is having issues today btw, will wait till things are better to re-start tests.

kamilogorek commented 8 years ago

@wraithgar could you rerun tests on Travis? It looks like it stuck

edit: Nice timing!

lukekarrys commented 8 years ago

+1

wraithgar commented 8 years ago

Published as v1.5.1