search

AmpersandJS / ampersand-events

Standalone event system that can be mixed into any object
MIT License
18 stars 7 forks source link

Should we ship this? #1

Closed HenrikJoreteg closed 9 years ago

HenrikJoreteg commented 9 years ago

I think it's pretty much ready to go. Can I get some review from @AmpersandJS/core-team so we can ship it?

wraithgar commented 9 years ago

Readme looks good. Tests do not run for me locally.

HenrikJoreteg commented 9 years ago

@wraithgar i blew away node modules, reinstalled, and they ran just fine. What errors are you seeing?

wraithgar commented 9 years ago

Mine was a clean clone + npm i :shrug:

I make it run tests like the other repose (node test | tap-spec) and left the test-ci/browser lines alone. If we want to change how we do tests let's, otherwise this is a +1 from me it all looks good now.

HenrikJoreteg commented 9 years ago

ok, once i get travis to run properly, i'll publish 1.0.0 and add it to the docs site.

kamilogorek commented 9 years ago

Code looks fine, tests run correctly as well. Clean clone, npm install, npm test. +1

HenrikJoreteg commented 9 years ago

Oh good! Because we already did. Lol

On Thu, Jan 22, 2015 at 8:53 PM, Kamil Ogórek notifications@github.com wrote:

Code looks fine, tests run correctly as well. Clean clone, npm install, npm test. +1

Reply to this email directly or view it on GitHub: https://github.com/AmpersandJS/ampersand-events/issues/1#issuecomment-71147566