search

AmpersandJS / ampersand-filtered-subcollection

Filterable, sortable, proxy of a collection that behaves like a collection.
MIT License
11 stars 7 forks source link

Fix conditional for triggering sort on change events #13

Closed legastero closed 9 years ago

legastero commented 9 years ago

The original conditional included the predicate:

    (propName && !sortable && includes([this.comparator, this.collection.comparator]), propName)

However, that last propName is not part of the includes() call like it was intended to be.

Thanks to the magic of commas, that makes the entire predicate true, and so we run a sort on any change event.

lukekarrys commented 9 years ago

+1

nlf commented 9 years ago

+1 good catch

latentflip commented 9 years ago

Woo!

latentflip commented 9 years ago

+1

lukekarrys commented 9 years ago

Published as v2.0.1