search

AmpersandJS / ampersand-filtered-subcollection

Filterable, sortable, proxy of a collection that behaves like a collection.
MIT License
11 stars 7 forks source link

Bubble comparator change events #24

Closed herkyl closed 9 years ago

herkyl commented 9 years ago

Fixes #22

This pull request changes it so that the change events of watched and comparator properties get bubbled. Let me know if there is an edge case where the subcollection should not bubble watched properties' change events.

wraithgar commented 9 years ago

+1 tests pass locally. I'm really glad we're getting more eyes on this and am in no way surprised my code had this many edge cases. There were a lot of moving parts here and I'm extremely glad for your help here.

lukekarrys commented 9 years ago

+1

lukekarrys commented 9 years ago

Thanks again @herkyl! Published as v2.0.4.

wraithgar commented 9 years ago

Thanks for staying on top of these merges and taking the time to publish @lukekarrys

herkyl commented 9 years ago

Thanks for the fast response guys! Our app (teamweek.com) relies very heavily on subcollections, I'm very glad I can fix a bug one day and move the fixed library to production the next.