search

AmpersandJS / ampersand-filtered-subcollection

Filterable, sortable, proxy of a collection that behaves like a collection.
MIT License
11 stars 7 forks source link

Fixed sorting collection when watchable property changes #27

Closed herkyl closed 8 years ago

herkyl commented 8 years ago

Collection was not getting sorted when a watchable property changed while comparator was a function

herkyl commented 8 years ago

Tests work locally.

wraithgar commented 8 years ago

Was there a reason you refactored two tests instead of adding new ones for this new use case? Sort of feels like we're losing coverage for cases where watched isn't set now.

herkyl commented 8 years ago

@wraithgar I think you are right, I will separate those tests

wraithgar commented 8 years ago

Ok great thank you for making this PR. Seems fine to me. +1

herkyl commented 8 years ago

Whats the status on this?

wraithgar commented 8 years ago

Was waiting on another +1 but I think a week's enough time to wait.

Can you revert the version in package.json and then I'll merge this. (The version bump is part of a separate publish process already)

herkyl commented 8 years ago

Done

wraithgar commented 8 years ago

Published as v2.0.5

wraithgar commented 8 years ago

Thank you!