search

AmpersandJS / ampersand-filtered-subcollection

Filterable, sortable, proxy of a collection that behaves like a collection.
MIT License
11 stars 7 forks source link

switch to lodash 3.x modules #6

Closed wraithgar closed 9 years ago

klaemo commented 9 years ago

I have a PR ready for this once ampersand-collection-lodash-mixin is published.

wraithgar commented 9 years ago

I'm thinking about burning a major version and removing the underscore mixin functionality being baked-in. If your PR is ready just remove the underscore-mixin from this module and we can hash it out. https://github.com/AmpersandJS/ampersand-filtered-subcollection/issues/8

klaemo commented 9 years ago

:+1: The tests use the underscore mixin in a couple of places as well, should I remove it there, too? or replace it with the lodash one and move it to devDep?

wraithgar commented 9 years ago

remove altogether please

klaemo commented 9 years ago

It's actually used in quite some places. I don't have the time to finish it now. Will do it later :)

wraithgar commented 9 years ago

switched in v2.0.0