search

AmpersandJS / ampersand-form-view

Completely customizable form lib for bulletproof clientside forms.
MIT License
26 stars 20 forks source link

Updated dependencies to survive get-object-path@0.0.2 being removed from npm #61

Closed achingbrain closed 8 years ago

achingbrain commented 8 years ago

Also phantomjs appears to have been renamed phantomjs-prebuilt so changed that too.

achingbrain commented 8 years ago

This will resolve #60

achingbrain commented 8 years ago

Hmm looks like the same sourcelabs credentials problem observed in AmpersandJS/ampersand-select-view#72 are happening on travis:

Error: Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided. See the zuul wiki (https://github.com/defunctzombie/zuul/wiki/Cloud-testing) for info on how to setup cloud testing.

fyockm commented 8 years ago

LGTM

wraithgar commented 8 years ago

+1 tests work locally for me.

Had to remove my node_modules and reinstall though, a heads up to future devs trying to get this to work. Still got the npm error w/ an old node_modules for some reason.

wraithgar commented 8 years ago

Actually now that I think about it we either need to roll back the lodash update in this PR, or move everything to 4.0. There will be a lot of duplication if we're not on the same major on this one.

achingbrain commented 8 years ago

Done.

cdaringe commented 8 years ago

+1

imorrison commented 8 years ago

:+1:

wraithgar commented 8 years ago

updated readme, will publish as 6.0.0 after travis/saucelabs build finishes

wraithgar commented 8 years ago

published as v6.0.0

achingbrain commented 8 years ago

Fantastic, thanks!