search

AmpersandJS / ampersand-input-view

A view module for intelligently rendering and validating input. Works well with ampersand-form-view.
MIT License
17 stars 19 forks source link

Call handleInputChanged in beforeSubmit #13

Closed imorrison closed 10 years ago

imorrison commented 10 years ago

This will recompute the derived property validityClass even if the the input element is never changed but submitted.

Fixes #12

HenrikJoreteg commented 10 years ago

Thanks for this, sorry for the delay. Can you add a test for this?

imorrison commented 10 years ago

Can you add a test for this?

For sure. I will try to see if I have some time to do that this week.

lukekarrys commented 10 years ago

First of all thanks for this fix @imorrison!

I just ran into this same issue, but found an edge case with this PR that I think I covered over in #21.

Basically, even when calling handleInputChanged in beforeSubmit it still hides the validityClass in cases where the input was "unchanged".