search

AmpersandJS / ampersand-input-view

A view module for intelligently rendering and validating input. Works well with ampersand-form-view.
MIT License
17 stars 19 forks source link

Doc update #37

Closed mmacaula closed 9 years ago

mmacaula commented 9 years ago

I found the documentation missing for rootElementClass so I figured I'd add it.

I also threw in another section on customization in the docs. I can remove this if you don't think it helpful.

Finally, the docs state that name is required, but it wasn't in the actual code. I wasn't sure if it should be, but for now I figured do no harm and just update the docs to reflect reality.

kamilogorek commented 9 years ago

Thanks @mmacaula! I think that it'd be actually a good idea to be able to pass multiple classes as a default behavior, without overriding a default implementation. Let's wait for other guys input. Cheers! Related: https://github.com/AmpersandJS/ampersand-dom/issues/14

bear commented 9 years ago

@kamilogorek is the example given in this PR invalid or can we merge this in to fix the docs and then file an issue discussing a better/different example to use?

kamilogorek commented 9 years ago

@bear we can get it in for now and change it once we take care of https://github.com/AmpersandJS/ampersand-dom/issues/13

bear commented 9 years ago

Thanks @kamilogorek - i'll merge it now!