search

AmpersandJS / ampersand-model

Observable objects, for managing state in applications.
MIT License
84 stars 31 forks source link

add fix for how amp sync treats error callbacks #39

Closed engenb closed 9 years ago

engenb commented 9 years ago

this pull request addresses #38

yocontra commented 9 years ago

Any ETA on merging this? Causing a ton of issues with some apps we have

lukekarrys commented 9 years ago

+1, fix looks good to me. I'll find another @AmpersandJS/core-team person to second this and we'll get it merged/published.

wraithgar commented 9 years ago

+1 do it @lukekarrys

HenrikJoreteg commented 9 years ago

+1 @lukekarrys @wraithgar. :shipit:

yocontra commented 9 years ago

What's the process for merging PRs? Documented anywhere? Seems a tad slow to wait for the whole team to chime in on a simple two line bug fix that includes tests

HenrikJoreteg commented 9 years ago

published as 4.1.0 silly me fatfingered it as a minor instead of patch release. But anyway, there it is.

Thanks @engenb!

@contra the typical process we have is 2 plus ones: http://ampersandjs.com/learn/bug-triage-process#pull-requests

HenrikJoreteg commented 9 years ago

We're also in the process of assigning lead maintainers for each repo so it's clearer who's the primary on each one.