search

AmpersandJS / ampersand-rest-collection

ampersand-collection with REST and lodash mixins for easy use with REST APIs.
http://ampersandjs.com/docs#ampersand-rest-collection
MIT License
23 stars 11 forks source link

Needs way more tape tests #1

Closed HenrikJoreteg closed 10 years ago

latentflip commented 10 years ago

Given this just combines two other modules, I'm not sure of it's need for lots of tests?

kamilogorek commented 10 years ago

Totally agree. As this is just a mix of 2 other components, there's no need for testing them here, they should be both tested separately.

Underscore Mixins (already tested): https://github.com/AmpersandJS/ampersand-collection-underscore-mixin/pull/4 REST Mixins: https://github.com/AmpersandJS/ampersand-collection-rest-mixin/issues/1

lukekarrys commented 10 years ago

After going through and adding tests for the rest mixin, I agree that this doesn't really need more tests.

I'm in favor of closing this. Objections @latentflip @HenrikJoreteg @kamilogorek?