Replace underscore with amp-* modules

AmpersandJS / ampersand-router

Clientside router with fallbacks for browsers that don't support pushState. Mostly lifted from Backbone.js.

MIT License

70 stars 16 forks source link

Replace underscore with amp-* modules #31

Closed vovacodes closed 9 years ago

vovacodes commented 9 years ago

Leave the underscore as a devDependency for test file, since there is no replacement for _.pick function available yet.

drewloomer commented 9 years ago

I came here to add this functionality only to see it's already been done. Can we get this merged in? I don't want to have to include underscore in my project.

wraithgar commented 9 years ago

Yeah let's go ahead and get pick removed and made it a clean break! http://amp.ampersandjs.com/#amp-pick

vovacodes commented 9 years ago

Will do that tomorrow and update the pull request

vovacodes commented 9 years ago

Updated, no underscore anymore

wraithgar commented 9 years ago

+1 looks good, tests pass locally for me too.

HenrikJoreteg commented 9 years ago

+1 here too, i'm ready to ship this. this should be safe to do as a patch update right?

wraithgar commented 9 years ago

Yep this is just an underlying dependency change w/ parity of features.

HenrikJoreteg commented 9 years ago

published as 1.0.7

HenrikJoreteg commented 9 years ago

thanks @wizardzloy!