search

AmpersandJS / ampersand-select-view

Select field for ampersand-form-views
MIT License
11 stars 26 forks source link

3.0.0 RC #36

Closed cdaringe closed 9 years ago

cdaringe commented 9 years ago

tldr: this PR is large. we can setup core-crew talky to go over this change if desired.

This PR fixes https://github.com/AmpersandJS/ampersand-select-view/issues/5. It addresses a variety of other opens as well.

Per the new README.md changelog:

changelog

  1. Improve general option edge cases, and add supporting test cases. Primarily targets falsy option value handling.
  2. Validate immediately to assist when parent FormView tests onload for field validity. Update skipValidation to skipValidationMessage, permit immediate validation, but conditionally display messages.
  3. Throw an Error when trying to setValue(value) and an option matching the requested value does not exist. The exception to this is when the provided value is null, undefined, or '', and a null option value exists. Because the DOM can only recognize a single empty value for any <option>, which is the empty string '', only a single empty-ish option can only be supported by the view.
  4. Support 0 value options, both in Model id's and array values.
  5. Add eagerValidate.
  6. Denote a plan for 4.x release
  7. bulk update README, and some cody tidying
kamilogorek commented 9 years ago

Wooh! Such a great work out here @cdaringe! You're right that this PR is huge, but after quick scan everything looks really good.

cdaringe commented 9 years ago

thanks @kamilogorek. what did you think of this class change? I'm not 100% on that.

wraithgar commented 9 years ago

Typically you have a single class name for things like that, regardless of input type. See things like bootstrap or foundation for examples.

cdaringe commented 9 years ago

thanks gar. i reverted those classes back

wraithgar commented 9 years ago

Travis is having problems today, tests pass fine locally.

wraithgar commented 9 years ago

Published as v3.0.0