Closed achingbrain closed 9 years ago
So this happens when this.el was never attached to anything, right? Makes sense to me.
Would you be willing to add a test to this to 1) make sure that remove
works as expected (removes this.el from a parent) under normal circumstances and 2) doesn't explode if there is no parent)? If not I can get to that a little later.
I've added a couple of tests as suggested.
+1 looks good thanks for doing this!
Hmm, Travis says:
Error: Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided. See the zuul wiki (https://github.com/defunctzombie/zuul/wiki/Cloud-testing) for info on how to setup cloud testing.
Not sure what I can do about that, sorry.
Nothing you can do, the saucelabs thing is a known issue w/ the testing for some of these modules. We just have to run tests locally for now.
+1, tests pass
you guys think we should add the tests to view-conventions additionally/instead?
Great idea. May have to make el an actual attached el in those tests though, do proper tests to make sure it got removed or something.
released as v3.0.1
Brings ampersand-select-view more in line with how ampersand-view does it, otherwise you occasionally get
Uncaught TypeError: Cannot read property 'removeChild' of null
.