search

AmpersandJS / ampersand-select-view

Select field for ampersand-form-views
MIT License
11 stars 26 forks source link

Bind change event listener to select, not el. #58

Closed hailwood closed 8 years ago

hailwood commented 8 years ago

Just a simple bug fix.

hailwood commented 8 years ago

That fail aint the codes fault.

ampersand-select-view@4.3.2 test-ci /home/travis/build/AmpersandJS/ampersand-select-view zuul -- test/index.js Error: Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided. See the zuul wiki (https://github.com/defunctzombie/zuul/wiki/Cloud-testing) for info on how to setup cloud testing.

cdaringe commented 8 years ago

+1, tests pass locally

kamilogorek commented 8 years ago

:+1:

cdaringe commented 8 years ago

it's a simple patch, but is potentionally breaking. will publish as major hopefully later today. @hailwood, mind patching the changelog in the readme @5.0.0?

cdaringe commented 8 years ago

published as 5.0.0