AmpersandJS / ampersand-select-view

Select field for ampersand-form-views
MIT License
11 stars 26 forks source link

Allow overriding template with extend #69

Closed timwis closed 8 years ago

timwis commented 8 years ago

This allows you to override the default template using

var myTemplate = '<select>...</select>'
var MySelect = SelectView.extend({ template: myTemplate })`

(which doesn't currently work).

This works the same way ampersand-input-view does it

timwis commented 8 years ago

FYI, the travis error message regards no saucelabs credentials being provided, so I'm assuming it's not to do with the code change

wraithgar commented 8 years ago

This is one of those tweaks that leaves one wondering "why didn't we do this in the first place?"

Thanks for your PR. Yes the test failure is due to a security constraint in travis.

Wondering if a readme update is in order for this or not.

+1 on the code pending readme discussion.

cdaringe commented 8 years ago

+1

cdaringe commented 8 years ago

i will update the README and publish

wraithgar commented 8 years ago

Thank you @timwis!

cdaringe commented 8 years ago

published as 6.2.0! thx