Added the tabindex option to match capabilities of ampersand-input-view.

AmpersandJS / ampersand-select-view

Select field for ampersand-form-views

MIT License

11 stars 26 forks source link

Added the tabindex option to match capabilities of ampersand-input-view. #70

Closed kylefarris closed 8 years ago

kylefarris commented 8 years ago

Title sums it up I think.

You can refer to this PR for more info: https://github.com/AmpersandJS/ampersand-input-view/pull/70

BTW, sorry for the later-than-expected PR. Completely forgot to submit this one too...

wraithgar commented 8 years ago

+1 from me I added notes so anyone else reviewing could quickly discern between the whitespace cleanup and the code that actually represents this PR.

kylefarris commented 8 years ago

That is weird... I was questioning my beautifying library when it changed those to the actual > and < characters but assumed it was proper... I'll turn them back to the entity versions in VIM and commit. Good find guys, sorry about all the clean up. I mean, I guess it's not a bad thing... just makes the PR a bit messy.

kylefarris commented 8 years ago

So, actually, it really seems like the bigger "issue" was the inconsistent way in which HTML elements were written in the markdown. Sometimes they were written without being wrapped in back ticks, other times they were. I changed all occurrences so that they are wrapped in ticks since I think the pre-formatted style is easier to read and probably more "proper" anyway.

cdaringe commented 8 years ago