search

AmpersandJS / ampersand-select-view

Select field for ampersand-form-views
MIT License
11 stars 26 forks source link

Update ampersand-view dependency #71

Closed achingbrain closed 8 years ago

achingbrain commented 8 years ago

Versions of ampersand-view before 9.0.2 depend on get-object-path@0.0.2 - this has just been removed from npm.

Any chance of this module updating it's ampersand-view dep?

wraithgar commented 8 years ago

Yes, a PR updating that dependency would most likely be quickly accepted.

achingbrain commented 8 years ago

Do you know what the breaking changes are between 8 and 9?

wraithgar commented 8 years ago

Yep! There were two small breaking changes in some defaults, outlined here: https://github.com/AmpersandJS/ampersand-view#changelog

I don't think those specifically affect this module, but because this is returning an ampersand-view a PR bumping 8 to 9 would constitute a major bump in this module.

imorrison commented 8 years ago

Okay, I just started opening up a couple PRs to help resolve this. I can't update the ampersand-form-view until the input and checkbox views are also updated :neutral_face:

imorrison commented 8 years ago

Something is wrong with the travis-ci config:

Zuul tried to run tests in saucelabs, however no saucelabs credentials were provided.

This appears in all of my PRs.

wraithgar commented 8 years ago

Sorry about that, external PRs fail cause of the way travis-ci handles encrypted vars.

achingbrain commented 8 years ago

Looks like timezones got the better of me and this has been done. Thanks!

wraithgar commented 8 years ago

Thanks for all your effort on these PRs @achingbrain

imorrison commented 8 years ago

Perfect, here is the final one: https://github.com/AmpersandJS/ampersand-form-view/pull/62

achingbrain commented 8 years ago

I think @imorrison has been doing all the work :wink: