search

AmpersandJS / ampersand-state

Core state management object.
MIT License
141 stars 75 forks source link

State.extend() destroys its inputs #68

Closed legastero closed 9 years ago

legastero commented 10 years ago

The extend() method has serval lines like: https://github.com/AmpersandJS/ampersand-state/blob/master/ampersand-state.js#L717

Which means that a mixin module that just exports a dictionary (say of datatype definitions) can only be used once anywhere in an app.

I could live with requiring mixin modules to export a function to create new copies on demand to get around this, but that's not how we're doing the mixin pattern for Collection mixins.

yallups commented 10 years ago

I have also encountered this and have had to make some work arounds.

HenrikJoreteg commented 10 years ago

hmm, interesting, we should fix that.

latentflip commented 9 years ago

Fixed in #111, released as 4.4.1